[Feature Request]: Suggestion to improve Accessibility
Closed this issue · 24 comments
Guidelines
- I have searched the issue tracker for a feature request that matches the one I want to file, without success.
- I have searched the documentation for information that matches the description of the feature request I want to file, without success.
Problem Description
- If i tab through the add to playlist menu it doesn't cycle through the playlists to so the user can never select them.
VirtualBoxVM_0nwSRWQvjt.mp4
- Here i have to tab through all my playlists before i can give my new playlist a name. I know i have only 2 playlists here but image if you have 100+ playlists.
VirtualBoxVM_BqTKBnVsIu.mp4
- I have to tab through every element to get to edit playlist name/description
VirtualBoxVM_WzMhO1XeHq.mp4
- I have to tab through every element to get to name and save my new playlist
VirtualBoxVM_Z31xlmMF3W.mp4
4.1. Expansion on 4, i can cancel the prompt where i need to select a playlist to add my videos to but i can still create a playlist
VirtualBoxVM_sXedP6lFFO.mp4
- When i press cancel i and press tab again i have to cycle through every element to get back to the playlist prompt
VirtualBoxVM_75fdSj2Ems.mp4
- When i add playlist it doesnt come back to the playlist prompt
VirtualBoxVM_UhhtWcJi4n.mp4
- Clicking on copy button brings me to prompt but if i cancel and press tab i'm not on the copy button anymore
VirtualBoxVM_NCP90pYTrl.mp4
- add or cancel playlist prompt does not bring focus back to thumbnail
add-button-playlist-video-page.mp4
- when i cancel or save my playlist it doesnt take me back to the add to playlist button under the video player
add-button-video-player.mp4
- when i cancel or save my video it doesnt take me back to the add to playlist button on the thumbnail
playlist-add-video.mp4
- clicking cancel on deleting playlist prompt doesnt take focus back to delete playlist button
del-playlist.mp4
- clicking cancel or save on removing watched video prompt doesnt take focus back on remove watched video button
rem-watched.mp4
- clicking cancel or save on playlist prompt doesnt take me back to copy button
cancel-save-copy-playlistt.mp4
- when saving a video to playlist doesnt give focus back to the thumbnail
save-playlist-prompt.mp4
- when cancel add video to playlist prompt it doesnt give focus back to the thumbnail
cancel-playlist-prompt.mp4
Proposed Solution
- 1. Would like to cycle through the playlists so i can select one of them in order to add my videos to it
- 2. Would like the focus to be on the input field after clicking on that button so i dont have to cycle through all my playlists to get to the input field
- 3. Would like the focus to be on the input fields instead of having to cycle through every element
- 4. Would like the focus to be on the input field so i can give my new playlist a name
- 4.1. IDK if there is a solution to this i just wanted to mention it and to get your thoughts on it
- 5. Would like the focus to be on the playlist prompt (not sure where maybe where it left off on the create new playlist button)
- 6. Would like the focus to be on the playlist prompt (not sure where maybe where it left off on the create new playlist button)
- 7. Would like the focus to be on the copy playlist button when i cancel/save playlist prompt
- 8. Bring focus back to thumbnail when i cancel/save prompt
- 9. take me back to the add to playlist button under the video player when i press tab
- 10. take me back to the add to playlist button on the thumbnail
- 11. take focus back on delete button
- 12. take foucs back on remove button
- 13. take focus back on copy playlist button
- 14. focus on thumbnail again
- 15. focus on thumbnail again
Alternatives Considered
None.
Issue Labels
ease of use improvement
Additional Information
No response
Done changes for 1&2 in b6b60f5
Test especially with both prompt visible
Tested 1&2 and LGTM
Edit: 4 is also fixed probably by nr 2.
2nd Edit: i think i have every part of the UI listed now, tried to be thorough with it
Is there any existing prompt that would refocus on previously focused element on dismiss?
If not then those might not be implemented soon
Hmm idk will test later today!
Also @ChunkyProgrammer does these suggestions even make sense from an accessibility standpoint? I mean to me it does and i think it works like this in the browser (am not sure about that though)
@PikachuEXE its very inconsistent how things are handled rn
In the privacy settings menu click Clear search cache or remove watch history -> use tab and press enter on no to cancel the prompt -> press tab again and see that the hamburger menu is on focus just like u saw in some of the screenrecordings
In the privacy settings menu click Remove all subscriptions / profiles -> tab to no and press enter -> press tab and see that focus is on the privacy settings tab
Not sure if this is the same because it opens a OS prompt for importing/exporting but in the data settings when u click on one of the options -> and cancel that prompt the button where u initially clicked on is still on focus.
There is on exclusion to this and that is the export Subscriptions setting because that does bring up a FT prompt. When u cancel that prompt and hit tab again the Data settings tab is in focus
Let's move non playlist related stuff into another issue (probably in main repo)
Otherwise this takes forever to finish playlist feature =_=
(3) should be fixed in a624a85
There is on exclusion to this and that is the export Subscriptions setting because that does bring up a FT prompt. When u cancel that prompt and hit tab again the Data settings tab is in focus
The reason is that the prompt element is rooted in that section, when prompt is closed = destroyed, the next focus target would still be picked from the last parent (I guess)
But this is not true with "global" prompt where the prompt element is rooted in "app"
To be able to auto focus on last focused element after closing a "global" prompt is another thing to do but should not be part of the playlist feature implementation
Can confirm 3 is fixed
if we cut out non related playlist stuff then i think we should only do 5/6/11/12
Done a change in e2b1f4f
Made prompt try to focus back to last focused element
But it doesn't work on invisible element (e.g. the button only visible on hover/activate)
tested 5/6/11/12 and all works
i'd like to suggest an better improvement on 6 though, now i focuses back on the create playlist button when u just created the playlist. I think its better to have the focus on the just created playlist.
I think its better to have the focus on the just created playlist.
I tried calling focus() but it's not visible coz the default focus style (from vue/electron?) is for :focus-visible
- https://developer.mozilla.org/en-US/docs/Web/CSS/:focus-visible
- https://trungk18.com/experience/focus-and-focus-visible/
But it's visible again with tab
As an alternative I can make it focus input again (1 more tab away)
Hmm okay then i would like to focus it on the seachbar so i can tab to that just added playlist, because maybe that person added that playlist but dont want the video to be added in there so in that case they can still deselect the playlist
Done in 349c363
LGTM!
Edit: all accessibility issues related to playlists are solved. I'll keep this open so i can migrate this when playlists are implemented.
Updated ft-list-video to focus back on thumbnail link after add playlist prompt opened by add playlist button closed
But focus style is invisible due to :focus-visible (but tab works and add playlist button visible)
1d41b23
Tested and looks like everything in this issue is addressed except for 4.1 but idk if something can be done about that
It's possible but might be a bit complicated
Kind of like preventing all other elements except top prompt from being tabbed
Which requires another level of changes and I won't do that in playlist branch (it's really about overall prompt implementation than just playlist)
ok i'll leave it open so i know i need to migrate this over later
(10) should re-tested
Since thumbnail link now updated to be unselectable (idea from FreeTubeApp#3954)
10 lgtm!
4.1 partially fixed by having focus shifted to current prompt
But there is nothing preventing people pressing shift+tab to press cancel
4.1 partially fixed by having focus shifted to current prompt But there is nothing preventing people pressing shift+tab to press cancel
LGTM, closing this issue.