PistonDevelopers/graphics

0.16.1 breaks consumers

Closed this issue · 1 comments

0.16.0 publicly exported texture-0.4.0::ImageSize, while 0.16.1 publicly exports texture-0.5.0::ImageSize. These types are different (in that an impl of one does not satisfy a requirement for the other) and the change breaks piston2d-opengl_graphics:

src/glyph_cache.rs:106:5: 114:6 error: the trait bound `texture::Texture: graphics::ImageSize` is not satisfied [E0277]
src/glyph_cache.rs:106     pub fn opt_character(&self, size: FontSize, ch: char) -> Option<Character> {
                           ^
src/glyph_cache.rs:106:5: 114:6 help: run `rustc --explain E0277` to see a detailed explanation
src/glyph_cache.rs:106:5: 114:6 note: required by `graphics::character::Character`
src/glyph_cache.rs:117:10: 117:45 error: the trait bound `texture::Texture: graphics::ImageSize` is not satisfied [E0277]
src/glyph_cache.rs:117 impl<'b> graphics::character::CharacterCache for GlyphCache<'b> {
                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/glyph_cache.rs:117:10: 117:45 help: run `rustc --explain E0277` to see a detailed explanation
src/glyph_cache.rs:117:10: 117:45 note: required by `graphics::character::CharacterCache`
src/glyph_cache.rs:120:5: 127:6 error: the trait bound `texture::Texture: graphics::ImageSize` is not satisfied [E0277]
src/glyph_cache.rs:120     fn character<'a>(&'a mut self, size: FontSize, ch: char) -> Character<'a> {
                           ^
src/glyph_cache.rs:120:5: 127:6 help: run `rustc --explain E0277` to see a detailed explanation
src/glyph_cache.rs:120:5: 127:6 note: required by `graphics::character::Character`
src/back_end.rs:312:6: 312:14 error: the trait bound `texture::Texture: graphics::ImageSize` is not satisfied [E0277]
src/back_end.rs:312 impl Graphics for GlGraphics {
                         ^~~~~~~~
src/back_end.rs:312:6: 312:14 help: run `rustc --explain E0277` to see a detailed explanation
src/back_end.rs:312:6: 312:14 note: required by `graphics::Graphics`
error: aborting due to 4 previous errors
error: Could not compile `piston2d-opengl_graphics`.

Agh of course, I'll yank 0.16.1 and publish 0.17.0. Thanks for the heads up.