PiyushSuthar/github-readme-quotes

Default system-defined light/dark color-scheme mode

Closed this issue · 5 comments

R055A commented

Would it be reasonable to implement a default light/dark mode instead of just light mode with equivalent functionality to the CSS prefers-color-scheme? That is, remove the requirement of a user manually entering their dark (or light) mode preference without affecting remaining existing functionality. If you agree to this @PiyushSuthar, can I please be assigned to the task.

PiyushSuthar commented

I don't know if prefers-color-scheme works in SVG. It'll be great if you add something like &theme=auto.

R055A commented

I don't know if prefers-color-scheme works in SVG. It'll be great if you add something like &theme=auto.

Hi @PiyushSuthar I can do that if you can assign me, please

  • 👍1
R055A commented

Hi @PiyushSuthar I have made a PR for this. I decided to implement CSS prefers-color-scheme rather than an equivalent. I chose not to use &theme=auto as light/dark mode is default anyway. However, it is up to you. If you want an additional auto in addition to light and dark then this can be done. Please, refer to the linked PR for more information.

  • 👀1
R055A commented

Hi @PiyushSuthar. How are you? Just a reminder that for this PR to be valid for Hacktoberfest it requires either being merged, having a hacktoberfest-accepted label added to it, or having an overall approving review by the 31st of October, thank you.

PiyushSuthar commented

Sorry for the late reply, and I've merged you PR.

Thank you for your contribution.