Setting merge UI behaviour differs from backend behaviour

Question

Setting merge UI behaviour differs from backend behaviour

Closed this issue 3 years ago · 4 comments

Describe the bug
When viewing merged settings that combine config from different encryption levels the merge behaviour used by Backoffice differs to that of the backend.

Currently the backend applies a shallow merge, wheres Backoffice uses a deep merge.

Expected behavior
Merged settings views should match across all system components.

Additional context
Some potential future complexity exists in this area via PlaceOS/core#86. To reduce fragility if this, or other similar changes it is likely worth ensuring settings merge behaviour takes place on the backend only.

Answer 1 · 2021-09-01T11:32:11.000Z

@MrYuion what build(s) is this available on? I'll give it a spin.

Answer 2 · 2021-09-02T00:13:49.000Z

Should be on the latest dev build.

Answer 3 · 2021-09-06T01:29:49.000Z

Confirming this is matching current backend behaviour.

Both components now perform a shallow merge with settings at higher encryption levels prioritised.

Answer 4 · 2021-09-10T06:47:52.000Z

@MrYuion it looks like this may only be available on build/dev currently. Can you please confirm here when available on build/prod by re-closing this issue.