normal_2 wrong offset in wardrobe

Question

normal_2 wrong offset in wardrobe

Closed this issue a year ago · 10 comments

WindUnwaken commented a year ago

Terms

I'm using the very latest version of CosmeticsCore and its dependencies.
I already searched on this Github page to check if the same issue was already reported.
I already searched on the plugin wiki to know if a solution is already known.
I already searched on the Discord server to know if anyone already provided a solution in the past for the issue.

Discord tag (optional)

No response

What happened?

plugin seems not have normal_2 functiong

Steps to reproduce the issue

check version of Cosmeticscore
use default file and remove normal
do reload
plugin give error

Server version

git paper-291

CosmeticsCore Version

1.2.3-r3

ProtocolLib Version

protocolib 5.1.1-669

LoneLibs Version

1.0.27

FULL server log

1.0.27

Error (optional)

[15:53:42 ERROR]: null
org.bukkit.command.CommandException: Unhandled exception executing command 'cosmeticscore:cosmeticsconfig' in plugin CosmeticsCore v1.2.3-r3
        at org.bukkit.command.PluginCommand.execute(PluginCommand.java:47) ~[paper-api-1.20.2-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:155) ~[paper-api-1.20.2-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.craftbukkit.v1_20_R2.CraftServer.dispatchCommand(CraftServer.java:991) ~[paper-1.20.2.jar:git-Paper-291]
        at org.bukkit.craftbukkit.v1_20_R2.command.BukkitCommandWrapper.run(BukkitCommandWrapper.java:64) ~[paper-1.20.2.jar:git-Paper-291]
        at com.mojang.brigadier.CommandDispatcher.execute(CommandDispatcher.java:265) ~[paper-1.20.2.jar:?]
        at net.minecraft.commands.Commands.performCommand(Commands.java:330) ~[?:?]
        at net.minecraft.commands.Commands.performCommand(Commands.java:314) ~[?:?]
        at net.minecraft.server.network.ServerGamePacketListenerImpl.performChatCommand(ServerGamePacketListenerImpl.java:2208) ~[?:?]
        at net.minecraft.server.network.ServerGamePacketListenerImpl.lambda$handleChatCommand$19(ServerGamePacketListenerImpl.java:2168) ~[?:?]
        at net.minecraft.util.thread.BlockableEventLoop.lambda$submitAsync$0(BlockableEventLoop.java:59) ~[?:?]
        at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1768) ~[?:?]
        at net.minecraft.server.TickTask.run(TickTask.java:18) ~[paper-1.20.2.jar:git-Paper-291]
        at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:153) ~[?:?]
        at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24) ~[?:?]
        at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1324) ~[paper-1.20.2.jar:git-Paper-291]
        at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:193) ~[paper-1.20.2.jar:git-Paper-291]
        at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:126) ~[?:?]
        at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1301) ~[paper-1.20.2.jar:git-Paper-291]
        at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1294) ~[paper-1.20.2.jar:git-Paper-291]
        at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:136) ~[?:?]
        at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1272) ~[paper-1.20.2.jar:git-Paper-291]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1160) ~[paper-1.20.2.jar:git-Paper-291]
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:315) ~[paper-1.20.2.jar:git-Paper-291]
        at java.lang.Thread.run(Thread.java:833) ~[?:?]
Caused by: java.lang.IllegalArgumentException: 'normal' model not set.
        at dev.lone.cosmeticscore.main.X.a(SourceFile:86) ~[CosmeticsCore_1.2.3-r3.jar:?]
        at dev.lone.cosmeticscore.main.j.a(SourceFile:250) ~[CosmeticsCore_1.2.3-r3.jar:?]
        at dev.lone.cosmeticscore.main.j.a(SourceFile:234) ~[CosmeticsCore_1.2.3-r3.jar:?]
        at dev.lone.cosmeticscore.main.d.a(SourceFile:54) ~[CosmeticsCore_1.2.3-r3.jar:?]
        at dev.lone.cosmeticscore.main.d.a(SourceFile:40) ~[CosmeticsCore_1.2.3-r3.jar:?]
        at dev.lone.cosmeticscore.main.b.onCommand(SourceFile:26) ~[CosmeticsCore_1.2.3-r3.jar:?]
        at org.bukkit.command.PluginCommand.execute(PluginCommand.java:45) ~[paper-api-1.20.2-R0.1-SNAPSHOT.jar:?]
        ... 23 more

CosmeticsCore config.yml

squirrel_tail:
    enabled: true
    display_name: "Squirrel Tail"
    type: BODY_ITEM
    model:
      gui: potion:400008
      normal: potion:400008
      normal_2: potion:410008
      self_2: potion:410009
    dye:
      enabled: false

Problematic items yml configuration file (optional)

squirrel_tail:
    enabled: true
    display_name: "Squirrel Tail"
    type: BODY_ITEM
    model:
      gui: potion:400008 ########remove "normal", try to test if "normal_2" is ready
      normal_2: potion:410008
      self_2: potion:410009
    dye:
      enabled: false

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

https://youtu.be/z-gmw1DGD0k

Answer 1 · 2023-11-21T10:22:30.000Z

If your server allows 1.20.2 and lower and also 1.20.2 and greater to join you have to use both model normal and normal_2.
If your server is only on > 1.20.2 or < 1.20.2 you have to use just normal model.

Normal model
A normal model is the model which is shown to every player but the local player (yourself).
This model is used only on Minecraft 1.20.1 and lower.

Normal model 2
This normal model is the model which is shown to every player but the local player (yourself).
This model is used only on Minecraft 1.20.2 and greater.

Please let me know.

Answer 2 · 2023-11-21T11:39:38.000Z

https://youtu.be/eWMg5TLUKYQ

Answer 3 · 2023-11-21T11:40:34.000Z

My server is only run on 1.20.2 and also client.
You can see video that cosmetics height is different from outside.

Answer 4 · 2023-11-21T18:17:19.000Z

Create also normal_2, let me know if it works correctly.
default_assets.zip

Answer 5 · 2023-11-21T18:22:39.000Z

It doesn't work.

Answer 6 · 2023-11-21T18:40:08.000Z

I will make another test but this is the default pack which was used to test the plugin before release... strange.

Answer 7 · 2023-11-21T18:41:23.000Z

blockbench plugin for 1.20.2 is perfect, only problem is in wardobe (cosmetics preview room)

Answer 8 · 2023-11-21T18:42:24.000Z

WindUnwaken commented a year ago

Answer 9 · 2023-11-21T18:50:21.000Z

I will make another test but this is the default pack which was used to test the plugin before release... strange.

I think that's not resourcepack issue, even resourcepack json is wrong, height of tail should as same as other one

Answer 10 · 2023-11-23T11:03:42.000Z

With the last zip I sent you I cannot reproduce the issue outside the wardrobe, shown in your Youtube video.

However I can trigger the wardrobe issue.
I will fix it in the upcoming update, thanks!

These are the debug images I use to highlight the different models.

textures:
body.zip
models:
body models squirrel tail.zip

Fixed:

Notes:

You can use only normal and self models in the yml configuration if your server is on 1.20.2 ONLY and 1.20.1 (and lower) cannot join.
No need to use normal_2 and self_2.
But in this case you would have to swap the normal with normal_2 model and also self with self_2, because my packs are meant to be working on every setup.