A small question, might be a dumb question
BookWyrm114 opened this issue · 4 comments
So considering that you said that the java version change broke alot of stuff, and that forge made alot of changes, I was wondering if it would be easier to build the mod using fabric instead. I know they're completely different, but someone made a port to a weird modloader called cursedfabric that's apparently similar to fabric: https://github.com/FluorideHistorian/WorldDownloader-Fabric, and someone else tried making a fabric port: https://github.com/ChadGamer82342/WorldDownloader, and a fabric mod similar to world downloader, but much less powerful (it's basically just a copy&paste feature for chunks, you go to a world, copy just whatever is in your render distance when you use the command, and then use a command to paste it in a singleplayer world): https://github.com/TheCSDev/mc-chunk-copy, So I was wondering if it would be possible to use parts of these mods' code since they've already done a lot of the work, and try porting to fabric because it might be easier, but also might not depending on your progress in updating the mod to 1.17/1.18 forge. Also there's an API called Architectury API that I think would be cool because it allows a mod to be built so it works on both forge and fabric.
(Basically I just think fabric support would be nice, and I know the answer is most likely "no", but I still wanted to ask, and I think the existence of the chunkcopy mod, along with the fact that it's open-source and updated for the latest versions of minecraft, would probably help with development of a fabric port)
Thanks for linking to these. I'll look over them in more detail when I get a chance.
To clarify, "forge made a lot of changes" isn't the issue; it's forgegradle, which is the build system (even the base-edit versions depend on forgegradle, though I think the fabric ecosystem uses its own different build system). These changes do mean I have to basically rework everything, which does mean I may want to switch to fabric's build system, but I'm not sure how practical that will be. There's also trying to keep all of the multi-version stuff working (including the automated tests that let me be semi-confident I haven't broken something without testing 20 different versions). There's also a lot of internal changes that would apply regardless of what platform I target (the change of chunks going from y between 0 and 255 to y between -63 and 319, for instance).
I do want to do a fabric build, though.
Thanks! A fabric build sounds awesome! and hopefully chunkcopy can help with the changes in world height.
Something else that might help is this. It's not actually a mod but a separate program that was designed to act as a proxy and let players download world from servers. it's not completely working on 1.18 yet, and it's not a mod, but it might help. https://github.com/mircokroon/minecraft-world-downloader
not sure if this is of any help but this fabric port: https://github.com/FluorideHistorian/WorldDownloader-Fabric
recently received an update, so maybe checking the code or talking to the person who seems to have contributed the code for that update (https://github.com/ChadGamer82342), who also made their own (now-abandoned) fabric port of WDL, might help.
though I don't think that the port is for 1.17+ versions of minecraft, so while it might help with porting the mod to fabric, it might not help with updating the mod to newer versions.
also, for multi-version stuff, you could try using multiconnect and/or viafabric as an optional dependency, that way players can use the newest version, but still join and download worlds on older servers, I think viafabric goes all the way back to 1.8.9 or lower, and multiconnect goes almost that low