Poly-Haven/polyhaven.com

Download does not work when ads block is enabled in the browser

Opened this issue · 3 comments

Karmavil commented

Hi. I am using Firefox 91.5.0esr (64-bit)
The download does not download anything when the user is using an ads block.
You should be able to catch that error and pop up a message.
I am really busy, late and really close to lose internet so I am sorry for not opening a PR.

Console output:

Failed to register/update a ServiceWorker for scope ‘https://polyhaven.com/__download__/’: Storage access is restricted in this context due to user settings or private browsing mode. download.js:1:393

The service does work in a private browsing session, that error occurred in a normal session with ads block enabled.

gregzaal commented

If you use Firefox and have "Delete cookies and site data when Firefox is closed" turned on, then you cannot download our assets. Solution: Disable this setting or use a different browser. More info: https://dev.webonomic.nl/fixing-firefox-failed-to-register-update-a-serviceworker-for-scope

A better error message for this should be shown yeah.

Karmavil commented

Hi Greg, you probably missed the last line:
"The service does work in a private browsing session, that error occurred in a normal session with ads block enabled."

That probably means that the plugin I am using gets disabled in a private window. I am pretty sure it is not related to the cookies but not sure entirely.. because using my current settings there are sites that make use of cookies to provide functionality and I get troubles with that, in example: Stackblitz

I just opened the bug because the user is not aware what's going on. An easy workaround is to start a private session window, but again this report is just to tell the user about this

gregzaal commented

We've had a few other reports of that same error, sometimes disabling the adblocker helps, but usually it boils down to the privacy settings in FF blocking the service worker for some reason.

I use uBlock Origin without any problem.

This isn't a priority right now as it affects a very very small number of users, but I will get to it at some point and display some proper informative error messages if we can detect these issues.

  • ❤️1