Why not allow non-square icons?
dhpollack opened this issue · 4 comments
It seems fairly trivial to add non-square icons. All one would have to do is change line change the cloneIcon function to allow for an x-size and a y-size and then change the set viewBox function to reflect this change. But perhaps there is a reason you only allow square icons.
Is there a reason we couldn't have an size for length and width so we could add non-square icon sets?
@cdata any opinion on this? I wouldn't mind creating a pull request to add this functionality.
I submitted a pull request to allow this: #13
If you set a viewBox attribute on your svg's, this change will respect that value instead of resetting it to the iconset size. I've been using this in my own project without any issues, but if you see a downside to this please let me know.
This looks like it's been fixed