PolymerElements/paper-radio-group

listen to changes in <content>

Closed this issue · 11 comments

D label get stuck in hidden mode

 <iron-localstorage name="club" value="{{ttt}}"></iron-localstorage>
<iron-localstorage name="option" value="{{option}}"></iron-localstorage>
                <paper-radio-group class="vertical layout" selected="{{option}}">
                    <paper-radio-button name="A">test1</paper-radio-button>
                    <paper-radio-button name="B">test2</paper-radio-button>
                    <paper-radio-button name="C">test3</paper-radio-button>
                    <paper-radio-button name="D">[[ttt]]</paper-radio-button>
                </paper-radio-group>

example http://gcl-12.appspot.com

click on the empty radio space first to select something to put it in localstorage then refresh the page.

image

@notwaldorf I think this is an issue with paper-radio-button's handling of textContent. It seems like the component needs to re-evaluate the label when textContent changes, not just on attached:

https://github.com/PolymerElements/paper-radio-button/blob/master/paper-radio-button.html#L112

(In Slack) @gertcuykens said he was on v1.0.6.

@arthurevans Yup, we're waiting on a Polymer change upstream that will let you listen to changes in <content>, which isn't possible right now.

do we have a estimate how long it wil take? or how long they have been working on it already :P

Pretty soon, actually! It's in the testing phase, so maybe 2 weeks? It's at the top of the stack, it just keeps getting pushed by slightly-more-important bugs.

Though, in the meantime: does this patch work for you? PolymerElements/paper-radio-button#49
I suspect you don't actually need the whole listener to work right now, but just the fix in that patch.

I wonder if there is a use case for labeling your radio buttons with icons only? In this case, hiding the label when textContent is empty would prevent you from doing that.

@arthurevans I've tagged a new release where we no longer hide the label at all, since that really doesn't work until listening to <content> works.

@gertcuykens would you mind pulling the new version of paper-radio-button and see if it fixes your issue, please?

So I Tried This at Home ™️ and it worked great, both with icons and with data-bound values.

radio-icons

👏👏 🎉

Super! Little victories! Closing as fixed :)

http://gcl-12.appspot.com/ yep 1.0.7 working for me too now :)

image

Ps how do you pull PolymerElements/paper-radio-button#49 if it is not in master yet ?
Could it be bucket-o-fixes is something private I can't access?

Oh, it's merged in master now, but normally you'd have to check out the branch locally (i think `git checkout pr/49 is the magical incantation) and run it from there