Dropping support for react 16 (and 15)
ryanthemanuel opened this issue · 6 comments
I noticed in 6.11.0 that support was dropped for react 16 and 15:
With this change, people that were depending on ^6.0.0 of react-onclickoutside and react 16 will pull in 6.11.0 and react 16 and be broken. From my understanding of major versions, that type of change typically necessitates a major version bump of the package that makes the change (in this case react-onclickoutside).
Agreed. This breaks several versions of react-datepicker, since it uses react-onclickoutside@"^6.8.0" as a dependency.
if so, that certainly wasn't intentional, the only thing that commit was supposed to do was bump the rollup and webpack versions to the point where things can actually be bundled without crashing again, with karma actually running the tests without crashing, too.
I'll have a look at why those bumps turned off support for React 15 and 16, because they shouldn't have.
Looks like the version bumps also messed with the react versions, turning the nice "^15.5.x || ^16.x || ^17.x" into the fairly useless "^17.x" so let's undo that immediately.
I've rolled back the react base and peer dependencies to what they were before, and pushed out v6.11.2, let me know if that fixes things because as far as I know, it should have.
@Pomax 6.11.2 has corrected this issue for me. Thank you for the quick turn around!
glad to hear it.