PortAudio/portaudio

Restore support for MacOS 10.5: it is a minimal fix

barracuda156 opened this issue · 2 comments

Commit aa05346 unnecessarily, I believe, dumped support for pre-10.6 systems. Could we restore it?
It is a minimal patch – leaving out the docs, it is a few trivial fallbacks. There is no added maintenance burden, and the patch can be further simplified by using a numerical version in the macro (i.e. 1060).

Are you suggesting directly reverting aa05346 or do you have a simpler patch in mind?

@RossBencina If comparison is done with a numerical value (1060), then ifndef condition above is unneeded, numerical constants do not have to be defined to work.
So it can be made 3 lines less.

I do not think modifying docs is important, so if restoring is not via revert, perhaps non-functional stuff can be dropped.

This leaves us with Xcode support restore (to include pre-4.2 versions) and a few fallback code instances in one file.