CMakeLists is missing library include directory
tatsuki-makino opened this issue · 2 comments
Describe the bug
When adding a library, include directory is not specified, so the build fails on an OS where that library is not included in the system.
To Reproduce
- using FreeBSD
- Building portaudio with alsa and sndio enabled.
Expected behavior
The build ends successfully.
Actual behavior
An error occurs due to undefined functions, etc.
A "porting" to apply the patch on FreeBSD side is required.
Desktop (please complete the following information):
- OS: FreeBSD
- OS Version: 12.4-STABLE (It has been tested. All versions are affected.)
- PortAudio version: 88ab584
Additional context
Not all CMakeLists.txt are checked.
A patch with suggested fixes will be attached.
It includes a fix to pass the path of the found shared library files directly to the linker.
This prevents problems when there are too many arguments for libdir.
Thank you. Please submit your patch as a pull request then it can be reviewed and merged.
@dmitrykos what do you think?