Proposal: rename "server" to "hub".
mariusandra opened this issue · 3 comments
The plugin server has a bunch of objects that it manages. A central one is called just "server", which contains all connections to various databases and some adapters to query them (PG, Redis, ClickHouse, Kafka, etc).
The name clashes with the "server" in "plugin server", which is the main entrypoint to the app.
Proposal: let's rename the connection object from "server" to "hub" to better reflect its intended usage.
Agree with this: or connections.
When first reading about the Plugin Server, I was very confused why there was a server inside the PluginServer that wasn't the PluginServer.ts
Big +1, I was thinking about an alternative name for some time but didn't come up with anything solid – hub sounds reasonable. Created #425 which makes this change.
I thought of connections as well initially, but it's not descriptive enough IMO. Hub also contains logic and abstractions over the various connections, so... :).