Currently only running with Prefix localhost - should run with any hostname for hosting outside
TylerLeonhardt opened this issue · 1 comments
right now, we only register:
this is fine for local testing but what doesn't work is when we want to expose it externally. If I want to use ngrok to tunnel my web server running on my machine, I need web server to be able to handle any host:
http://8a3f3451.ngrok.io
for example.
We will also need this if we want to run Polaris in a container. Same reasons above.
- Figure out what set of prefixes solve this for Windows, MacOS, and Linux (via container)
- figure out if admin is needed
For Windows, a prefix of: http://+:(port)/ did the trick. It DID require admin. A solution that doesn't require admin that I think is out of scope of this issue is the following complete prefix: http://+:80/Temporary_Listen_Addresses/ If there's enough want of a way to host without admin, I'll open a bug to support this prefix.
I have a branch that contains some code that checks if the OS is Windows and if so, it checks if the process has admin permissions. If so, then we're good to go to add the + prefix. Now I need to look at a solution for MacOS and Linux (docker).
fixed in #22