PredictiveEcology/SpaDES

Use fastdigest::fastdigest for hashing in Cache

eliotmcintire opened this issue · 6 comments

eliotmcintire commented

For large objects, digest::digest can take non trivial amount of time for both read and writing events (i.e., to assess its hash). A younger package, fastdigest, appears to be much faster. I am currently testing it for the various tests, including across platform.

  • Passes all unit tests on
    • Windows
    • Mac
    • Linux

@achubaty -- will need you to run tests on Mac. Currently, new code is in a feature branch CacheFastdigest

achubaty commented

ok. note that travis is checking on OSX, in addition to linux.

achubaty commented

NOTE: this will mean changing the CHECKSUM files again and updating all modules in the repo, and notifying users to do the same

eliotmcintire commented

Since downloadModule and downloadData do not use the Cache mechanism currently -- though they may in the future with @MelinaHoule download code -- this does not affect checksums of modules and data

achubaty commented

ah, ok. so you're only making this change to Caching.

eliotmcintire commented