Array indexing errors in llf_mhd_rel_no_transform.cpp
Closed this issue · 2 comments
smressle commented
The prim_l and prim_r arrays in hydro/rsolvers/mhd/llf_mhd_rel_no_transform.cpp are indexed incorrectly.
Instead of prim_l(IDN,i) they are indexed prim_l(IDN,k,j,i). This causes undefined behavior for the primitive values and in my case nans. The other llf files seem to be correctly indexed.
smressle commented
Yes this works! (sorry for the late response)
…On Tue, Apr 2, 2024 at 12:03 PM Kyle Gerard Felker ***@***.***> wrote:
Closed #568 <#568> as
completed via a9cc89e
<a9cc89e>
.
—
Reply to this email directly, view it on GitHub
<#568 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB6S4RQXHOZCLAKSUF6G3N3Y3LJE5AVCNFSM6AAAAABEHRZQN2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGMZDQNBZGI4DGMI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>