Reduce Dependencies

Question

Reduce Dependencies

Closed this issue 3 years ago · 3 comments

Hi there,

I was wondering if KeychainAccess is really a needed dependency as it's used in a single place for a simple read/write operation?
Cant this be replaced by a native keychain implementation to avoid adding extra dependencies?

I know it's a simple library and you don't have many dependencies, but when added to our project, that already requires quite a few dependencies, the lesser the better.

Thank you

Answer 1 · 2021-10-21T20:23:56.000Z

Created a PR to replace the dependency with the native implementation

Answer 2 · 2021-10-25T09:49:28.000Z

hi! we will review your pull request before the next release. Thank you for your collaboration.

Answer 3 · 2021-11-08T09:42:57.000Z

Hello again. Please update to version 0.0.7. We introduced a new PrivoKeychain implementation and delete dependency on KeychainAccess. Thank you for your feedback and code!