md5sum frequently needs update in master
springmeyer opened this issue · 4 comments
After 35ab470 we now build against osrm-backend master for commits to node-osrm master.
I think this setup is good, but there is one drawback: changes to the profiles break node-osrm test data setup because we assert against a checksum stored inside node-osrm. Just this week there have been several profile changes merged into osrm-backend master: https://github.com/Project-OSRM/osrm-backend/commits/master/profiles so it is expected that node-osrm will be broken daily.
Possible ways to keep data integrity checks (for when they count) but reduce this friction:
- Ignore data integrity checks for node-osrm builds against osrm-backend
master, but continue asserting when building against an osrm-backend tag or other release - Generate the md5sum file in osrm-backend and allow node-osrm builds to download it to assert
- Other ideas?
Related: once we ship profiles (#260) we no longer have to download them in the test directory. Taking profiles directly from the osrm-backend installation directory should solve this problem.
we no longer have to download them in the test directory.
Except in the case of building against an external osrm-backend, which is something @TheMarex does (and likely others).
Other idea: I know it's been discussed to death already, but: move node-osrm into osrm-backend. NodeJS is now required by osrm-backend to run tests, so it's only a small step to including nan.
This would prevent profile duplication, and simply the build/release process.
obsolete per #307