Project-Path-of-Exile-Wiki/PyPoE

[Item export - 3.16] Some base types fail due to conflicts

angelic-knight opened this issue · 5 comments

Some base types fail due to conflicts. I'm suspicious this has to do with royale items.
image
This needs investigation as to what items are conflicting with these that are failing, and a conflict resolver written to rename or exclude (is this possible?) the duplicates that we don't care about.

My branch may have just been out of date with respect to some changes in /patches, or things may have already been identified as royale items and are intentionally being fixed. Worth asking in the tooldev channel about this one before spending time on it.

Here's a list of Royale items I found that made it into the wiki:
image
They were often causing issues for unique items that had these base types as multiple items of the same name were being found.
They were sometimes usurping links that were meant to go to the real base item instead of the Royale one.

While we could update the unique items to reference page names and fix the other issues, the approach we're going with right now is to exclude Royale items from the wiki.
Cc: @markliu06

As far as i know, if adding the drop disable parameter, then the royal version of the item, will not be picked up by il template

But if we has planned that all these items are not needed, just add to the skip list as well as adding the associated disambiguation for the main item

Yeah, we'll need to update this area of item.py:
image
I think line 894 there was wrong anyway, it was naming the non-royale bow ... (Royale).

think line 894 there was wrong anyway

Yes, it seems my typo

markliu06@395291a

which probably need to change whole royale disambiguation list to without "Royale" in the metadata id and without the disambiguation term inside ""

'Metadata/Items/Weapons/TwoHandWeapons/Bows/Bow1 ': "",

and add the royale item to the skip list somewhere

'Metadata/Items/Weapons/TwoHandWeapons/Bows/Bow1Royale ',