ProjectOpenSea/operator-filter-registry

It is necessary to add support for upgradeable smart contracts

Closed this issue · 6 comments

It is necessary to add support for upgradeable smart contracts

I too think we need to support upgradeable smart contracts.

Thanks for creating an issue! What problems are you encountering with integrating OperatorFilterer or DefaultOperatorFilterer into an upgradeable smart contract?
It's true that ExampleERC721 and ExampleERC1155 are not upgradeable, but they are intended only as examples of how to integrate the project into a new smart contract.

when i try to use DefaultOperatorFilterer in UUPS proxy implementation, Hardhat shows error:

Error: Contract ... is not upgrade safe

contracts/DefaultOperatorFilterer.sol:9: Contract DefaultOperatorFilterer has a constructor
Define an initializer instead
https://zpl.in/upgrades/error-001

contracts/OperatorFilterer.sol:12: Contract OperatorFilterer has a constructor
Define an initializer instead
https://zpl.in/upgrades/error-001

I want to use openzeppelin-upgrades.
There are some restrictions to do so.

https://github.com/OpenZeppelin/openzeppelin-upgrades

Thank you - we will be adding contracts that follow OpenZeppelin's upgradeable pattern sometime today.

This should be addressed with PR #13. Please reopen if you run into more issues.