1271 signature verification fails when used for bulk signature

[XD-OK]

description

bulk signature introduced different signature lengths (not 64 and 65). When validating signatures with 1271, originSignature is used instead of extractedSignature, which can lead to signature verification failure.

seaport/reference/lib/ReferenceSignatureVerification.sol

Lines 51 to 55 in a07d085

	_assertValidEIP1271Signature(
	signer,
	originalDigest,
	originalSignature
	);

seaport/reference/lib/ReferenceVerifiers.sol

Lines 110 to 116 in a07d085

	_assertValidSignature(
	offerer,
	digest,
	originalDigest,
	signature,
	extractedSignature
	);

seaport/contracts/test/EIP1271Wallet.sol

Lines 69 to 77 in a07d085

	// NOTE: this is obviously not secure, do not use outside of testing.
	if (signature.length == 64) {
	// All signatures of length 64 are OK as long as valid is true
	return isValid ? _EIP_1271_MAGIC_VALUE : bytes4(0xffffffff);
	}
	if (signature.length != 65) {
	revert();
	}

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.