ProjectOpenSea/seaport

Why not use safeTransferFrom for ECR721 ?

davidseroussi opened this issue · 1 comments

Taken from the documentation of _performERC721Transfer in TokenTransferrer.sol:

Note that this function does not check whether the receiver can accept the ERC721 token 
(i.e. it does not use `safeTransferFrom`).

Why make this choice ? It breaks Smart Wallets usage that perform checks and actions when an ERC721 is received. Is the goal only to reduce gas usage ?

Would you accept a PR for adding the call to onERC721Received in case the offerer is a contract (EIP1271) ?

Thanks

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.