ProjectOpenSea/seaport

Remove duplicated logic

ne2030 opened this issue · 0 comments

At the ReferenceBasicOrderFulfiller.sol 661-754 line, there is a logic for creating a consideration array and hash for additional recipients. I think the first for loop already iterates all additional recipients, but there is another for loop that iterates additional recipients again. Second for loop's logic is just push receivedItem of tipped recipients to consideration array, but it's already done by first for loop.

For better readability, how about changing the first for loop to iterate only totalOriginalAdditionalRecipients? Continuing inside for loop is a little confusing and the second for loop is already separating tipping logic from the first for loop.

If there's any misunderstanding, please let me know. Thank you!