PromyLOPh/pianobar

QuickMix has no station modes

haarp opened this issue · 3 comments

haarp commented

Subject of the issue

Related to #700

When a QuickMix station is active, pianobar will fetch availabe modes, but since there are none, the experience is very confusing. It looks as if it's prompting for a name. Additionally, there seems to be a string mistake, as Delete is visible during the selection

Your environment

pianobar-2020-11-28 on Gentoo Linux

Steps to reproduce

  • Start pianobar into QuickMix
  • Press =
    [?] Delete Manage [m]ode? <- Delete isn't supposed to be here, is it?
  • Press m
(i) Fetching modes... Ok.
[?] Pick a new mode:
  • User is left confused here.

Expected behaviour

If no modes are available, don't prompt. I'm not sure if Pandora even offers modes for QuickMix. Probably not?

Actual behaviour

Confusing UI

Thanks! :)

PromyLOPh commented

Hi! I was thinking about merging x (which changes quickmix station assignment) into =. Not sure about that yet, so I guess we’ll take the shortcut. Does this patch fix the issue for you? https://6xq.net/paste/pianobar-quickmix.patch.html

haarp commented

This patch works well for me. Thanks!

I also approve of merging x. More context-based interactive menus in favor of obscure keys is good (I didn't even know about x until now) :)

PromyLOPh commented

I merged the fix and will reopen until I moved x into the context menu.

  • 👍1