PublicRadioInternational/embed-containers

Multiple Instances of the same embed affect one another within a story

Closed this issue · 7 comments

JXVD commented

Repro Steps

  1. Create an embed
  2. Create another version of that embed from the existing embeds tab
  3. Edit one of those embeds
  4. Edit the other embed

Expected Functionality

Actual Functionality

The embed that was edited second will populate with the edited values of the first upon opening the edit modal.

JXVD commented

Unsure if this is a bug or if it is proper functionality

ethorne commented

@JXVD are these the same embed type but not the same actual embed?

ethorne commented

this could be related to #217

JXVD commented

Unlikely, this is just an issue with how the embed populates it's values from the server. The only change that would ever need to be made would be simply updating both the embeds upon saving one of them. Just making sure that both embeds referencing and affecting the same data is correct.

ethorne commented

This is a nonissue. We cannot push updates to html pages that have already been loaded.

JXVD commented

We could update other versions of the embed within the editor. This is a minor issue though.

ethorne commented

Yes, this is true. We should bring this up at the next meeting.