Change required to Leeds PHR Sign Out

Question

Change required to Leeds PHR Sign Out

Closed this issue 6 years ago · 12 comments

Having moved the UI to use our own OpenID Connect Server for authentication, I've discovered that the mechanism I previously figured out for user sign out was working incorrectly (though it did work against the Gov.UK Verify sandbox).

What I now need you to do is as follows:

when the PulseTile User Sign Out button is pressed, it should send the GET /api/logout request as before
the response returned will now provide you with a JSON body containing a redirection URL, eg:
```
   {
         redirectURL: 'http://www.mgateway.com:8089/session/end'
    }
```

PulseTile should:

delete the JSESSIONID cookie
make a redirection to the redirection URL, eg
```
 window.location=response.redirectURL;
```

That's all that PulseTile now needs to do.

The OpenID Connect server will do the rest, removing the logged in user from its session information and deleting its own cookies, and will ultimately redirect the browser back to the PulseTile home page. From there, PulseTile will take over, re-directing back to the OpenID Server which will bring up the username/password form.

I've made a hardwired change to the UI at dev.ripple.foundation:8000 which demonstrates how it will now work

Answer 1 · 2018-06-12T09:01:46.000Z

Tested on 9999999000 and 99999990015 users - sign in / sign out at dev.ripple.foundation:8000 works properly.

@tony-shannon can we consider the task is done ?

Answer 2 · 2018-06-12T09:52:02.000Z

thanks Julia
I suggest you leave your Helm PHR browser tab open for a while and then see if logouts work fine.
The Helm PHR demo needs a lot of testing to iron out bugs so I would rather this is retested several times before closing please
thanks
Tony

Answer 3 · 2018-07-05T08:10:15.000Z

Update on 04.07.2018

Sign in / sign out for 9999999000 and 99999990015 users at dev.ripple.foundation:8000 works properly for the following browsers:
Desktop:

Chrome - YES
Mozilla - YES
Safari - YES
IE11 - there is an issue, it's being fixed right now
Mobile:
Safari iOS11 - YES
Chrome - YES

@tony-shannon after we fix issues with IE11, can we consider this task as Done?

Answer 4 · 2018-07-09T22:26:47.000Z

@kuvakina Yes you can, thanks

Answer 5 · 2018-08-14T15:06:14.000Z

UPD:

IE11: We can log in now, log out but sometimes loading takes too much time (around 7-20 sec). And sometimes you have to reload the page or clear cookies to log in / log out.

We'll look how to fix it.

Answer 6 · 2018-08-15T13:02:10.000Z

thank you @kuvakina

Answer 7 · 2018-09-20T13:53:46.000Z

@tony-shannon

Considering the error #176 , should we leave this issue open for now?

Answer 8 · 2018-09-27T10:22:40.000Z

@olegmdev when you have some time, please can you work with @kuvakina and pick this up please.

Answer 9 · 2018-10-03T10:53:02.000Z

I see myself in Assignees list, how I can help you with this issue? Cause I think I loose context of the project long time ago.

Answer 10 · 2018-10-04T11:43:34.000Z

Created the issue for this bug - #236

And asked Oleg to look into it.

Answer 11 · 2018-10-22T15:46:09.000Z

with #236 remaining open, @kuvakina I think this issue can be closed, please can you confirm

Answer 12 · 2018-11-01T17:34:29.000Z

@PhilBarrett yes, I think we can close this issue, as we don't have problems with logout.