PulseTile/PulseTile-React-Core

Pulsetile requires a Dockerfile

pacharanero opened this issue · 4 comments

pacharanero commented

Having a Dockerfile in the root of the project enables several useful things:

  1. Running Pulsetile in a Docker container locally for development. The use of a container isolates it from any other conflicting dependencies on the host machine.

  2. Automated builds of a Pulsetile Docker container on Docker Hub. We don't have a current need for this, but it may be useful in deployments in the future.

pacharanero commented

I am happy to be assigned this

PhilBarrett commented

@pacharanero we have this under review at the moment, do you have an update please?

pacharanero commented

Hi @PhilBarrett

Yes, this issue can now be closed by merging this PR #270

pacharanero commented

Also need to merge #270 to pull in my remote change. It is still awaiting the integration tests though, give it 5 mins.