PureStorage-OpenConnect/pure-fa-openmetrics-exporter

The OpenMetrics exporter is incorrectly calling the /hardware endpoint

Closed this issue · 3 comments

emaiello commented

Hello,

It sounds like the OpenMetrics exporter is reporting the wrong status while we perform a GET request against the /hardware endpoint and instead a proper drive status while using the /drives endpoint.

// More on the linked internal issue reported.

The Pure API version in use for this test is 1.9
Swagger reference: Pure1 Public REST APIs: https://static.pure1.purestorage.com/api-swagger/index.html

Could you please have a look on this?
Thanks!

sdodsley commented

This issue is actually that the /hardware endpoint is returning the incorrect information. This should be fixed, rather then fixing the exporter.
The endpoint error is a bigger issue affecting more than just the exporter.

  • 👍1
sdodsley commented

Based in the engineering JIRA comments, the /hardware endpoint only reports the health of the bay, not the actual drive, so this looks like a valid feature request to add the /drives endpoint

  • 👍1
chrroberts-pure commented

Interesting find! I’ll have to think about how we implement this since they have the same “name” key which is what lead to this confusion. Thanks for the issue.

  • 👍1