Py-KMS-Organization/py-kms

Freeze requirements properly

simonmicro opened this issue · 2 comments

As already pointed out here: #66 (comment) we should freeze the requirements in e.g. a requirements.txt file.

As I worked with Python Poetry recently and was pleasantly surprised by its features, I would propose that system instead. What do you guys think? Any strong feelings out there?

I don't have any strong opinions for or against Python Poetry (aside from its use of TOML for the pyproject.toml file 🤮). It seems to yield us much the same features of just simply using PIP, but if you wish to implement this for package and dependency reconciliation over Python PIP then feel free, my only concern would be the requirement to go and get Python Poetry from PIP before you could install our deps, seems pointless when you could cut out a step to just to pip3 install -r requirements.txt

I've just reviewed #68 and it looks good... There are still some details to be fixed, but there is a good chance that I'll merge it later on and resolve this (even without Poetry 😁 ).