PySport/kloppy

Different start time second half SkillCorner and DataFactory compared to other Providers

UnravelSports opened this issue · 0 comments

Looking through SkillCorner Tests and DataFactory Tests it seems for both of these providers the second half start time is 2700 where as for some other providers (Opta, StatsBomb, Sportec) the second half start time resets to 0.

If I'm seeing it correctly in Sportec Tracking Data Tests we are testing the second period starts at 0.

second_period = dataset.metadata.periods[1]
for frame in dataset:
    if frame.period == second_period:
        assert (
            frame.timestamp == 0
        ), "First frame must start at timestamp 0.0"
        break
else:
    # No data found in second half
    assert False

I'm not quite sure if we're doing a similar test for Sportec Event Data.

Now I don't know what the preferred behaviour is, but I would guess the preferred behaviour would be for all of these settings to be the same across providers and event + tracking data, no?