[Bug report] When unequiping an item that changes the LP / SP, the bar is not always refreshed
Talmit opened this issue · 5 comments
Describe the bug
When unequiping an item that changes the LP / SP, the bar is not always refreshed. This does not seem to happen when the SP change to maximum / from maximum.
To Reproduce
Steps to reproduce the behavior:
- Select a character that has already lost SP
- Unequip an item that provides SP (e.g. Lich Crown)
- Observe the SP indicator during equip / unequip
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
Nelvin (with lost SP)
Sabine (with maximum SP); This works correctly
Desktop (please complete the following information):
- OS: Windows 11
- Version 1.9.3 / Ambermoon Advanced 1.3
Additional context
The first provided save has Nelvin equipped with the crown.
I don't think this is a bug. The item just influences the maximum, not the current value. The current value is only changed if it would exceed the maximum.
If it would influence the current value you could just unequip and re-equip the crown at 0 SP to gain SP. This could be exploited.
It shouldn't influence the current values, but that's not what I was trying to describe.
If you take a look at the screenshots with Nelvin, in the first screenshot the max SP are at 223, while the current SP are at 118. This means he has ~53% of his SP available.
In the second screenshot he has max SP 198 and current SP 118. This makes for 59.5% of his SP available.
The bar next to Nelvin's portrait which indicates his SP stays the same with the item equipped as well as with the item uneqipped.
I noticed the same behaviour in another instance as well, namely after unequipping the "Mond Amulett" from my own character:
Initial (full HP / SP with Amulett):
After unequipping the Amulett (full HP / SP without Amulett):
After equipping the Amulett (partial HP / SP with Amulett):
After unequipping the Amulett (full HP / SP without Amulett, but the indicator shows missing HP next to the portrait):
If you take a look at the HP / SP and Max. HP / Max. SP you'll notice that in the first screenshot Aret has full HP / full SP. I just unequipped the Mond Amulett. However, the blue / green bars indicating HP / SP do not refresh themselfes.
I fixed some missing calls for the LP/SP bar update. Hopefully it works now. Will be part of the next release.
Should be fixed in 1.9.5. Feel free to reopen if something is still not working