Update pull_request_template.md

Question

Update pull_request_template.md

Closed this issue 3 years ago · 4 comments

manasb15 commented 3 years ago

This point in the checklist :

(I have added my name in the contributors list at the end of README.md file.)

is obsolete. So it is wise to remove it.

@QAZIMAAZARSHAD please assign this to me under DCP21

Answer 1 · 2021-07-12T06:41:22.000Z

Yesterday you said it helps you in remembering git commands.

I want to tell, you can do these changes without using git quickly.
Just open the pull request template file in your repo, remove the line, commit changes, make PR. And its done.

Answer 2 · 2021-07-12T06:44:45.000Z

@QAZIMAAZARSHAD Yes I know that method as well but I heard that it was like a shortcut or bad practice.

Answer 3 · 2021-07-12T06:47:49.000Z

@QAZIMAAZARSHAD Yes I know that method as well but I heard that it was like a shortcut or bad practice.

Yaa in the case of many changes it causes difficulty in merging and few other problems like unnecessary indentations etc.

Answer 4 · 2021-07-12T06:49:57.000Z

@QAZIMAAZARSHAD Ok then i will update it online for these small changes