QData/spacetimeformer

One sample missed?

qAp opened this issue · 1 comments

qAp commented

+ time_resolution * (-target_points - context_points),

If total length is 10, context length is 3, and target length is 2. Then, the last possible starting index is 5, with context = [5, 6, 7] and target = [8, 9]. But range(10 - 3 - 2) doesn't include 5.

Thanks yeah looks like we're leaving out the final timestep of each dataset split. I added +1 to that range, should be in the next PR.