QOSGroup/qos

active-validator命令参数tokens可选

Closed this issue · 4 comments

wangkuanzzu commented

1.不加参数tokens，可以执行
2.加参数tokens，参数值必须大于0

TokenxyWZY commented

已修改,待测试

wangkuanzzu commented

1.不加tokens参数，测试通过。
2.使用tokens参数，0或大于0的，测试通过。
3.使用tokens参数，小于0的情况，会使全网崩溃。

[vagrant@vagrant-192-168-1-201 ~]$ qoscli tx revoke-validator  --owner acc0 --validator qosval13h67w78aew28c549a49336h6kxfu4gaka79rhx
Password to sign with 'acc0':
{"check_tx":{"gasWanted":"9223372036854775807","gasUsed":"1807168","events":[]},"deliver_tx":{"gasWanted":"9223372036854775807","gasUsed":"1821500","events":[{"type":"revoke-validator","attributes":[{"key":"dmFsaWRhdG9y","value":"cW9zdmFsMTNoNjd3NzhhZXcyOGM1NDlhNDkzMzZoNmt4ZnU0Z2FrYTc5cmh4"},{"key":"b3duZXI=","value":"cW9zYWNjMTNoNjd3NzhhZXcyOGM1NDlhNDkzMzZoNmt4ZnU0Z2FrOXd0cTN0"}]},{"type":"message","attributes":[{"key":"bW9kdWxl","value":"c3Rha2U="},{"key":"Z2FzLnBheWVy","value":"cW9zYWNjMTNoNjd3NzhhZXcyOGM1NDlhNDkzMzZoNmt4ZnU0Z2FrOXd0cTN0"}]}]},"hash":"F1A9D77074F5C9459FAF14E618FD31675FD48609EB25C94634A30E91E39A24C5","height":"57"}
[vagrant@vagrant-192-168-1-201 ~]$ qoscli tx active-validator  --owner acc0 --validator qosval13h67w78aew28c549a49336h6kxfu4gaka79rhx --tokens -100
Password to sign with 'acc0':
null
ERROR: broadcast_tx_commit: response error: RPC error -32603 - Internal error: Timed out waiting for tx to be included in a block

image

wangkuanzzu commented

use qos version : branch -> develop
The bug has been fixed and the result of verfication as follows:

[vagrant@vagrant-192-168-1-201 ~]$ qoscli tx active-validator --owner acc0 --validator qosval1zmryfgcn4gm7zvrsg39w7t7r4xqq4fn2pq55t5 --tokens -100
null
ERROR: tokens must be positive

[vagrant@vagrant-192-168-1-201 ~]$ qoscli tx active-validator --owner acc0 --validator qosval1zmryfgcn4gm7zvrsg39w7t7r4xqq4fn2pq55t5 --tokens '100-10'
null
ERROR: invalid value of tokens