QtExcel/QXlsx

Let's add Dead Link Checker to CI/CD

Closed this issue · 2 comments

Should we add Dead Link Checker to QXlsx CI/CD? For example this code contains dead link... For example we can use this checker.

My log

a@Asya:~/QXlsx$ lychee QXlsx/source/* -m 0
  37/37 ━━━━━━━━━━━━━━━━━━━━ Finished extracting links                                                                                                                                                                                       Issues found in 4 inputs. Find details below.

[QXlsx/source/xlsxdocpropscore.cpp]:
✗ [ERR] http://www.w3.org/2001/XMLSchema-instance | Failed: Too many redirects: error following redirect for url (http://www.w3.org/2001/XMLSchema-instance)
✗ [ERR] http://purl.org/dc/elements/1.1/ | Failed: Too many redirects: error following redirect for url (http://purl.org/dc/elements/1.1/)
✗ [ERR] http://purl.org/dc/dcmitype/ | Failed: Too many redirects: error following redirect for url (http://purl.org/dc/dcmitype/)
✗ [ERR] http://purl.org/dc/terms/ | Failed: Too many redirects: error following redirect for url (http://purl.org/dc/terms/)

[QXlsx/source/xlsxworksheet.cpp]:
✗ [ERR] http://a.com/aaa.html#aaaaa | Failed: Network error: error sending request for url (http://a.com/aaa.html#aaaaa)

[QXlsx/source/xlsxformat.cpp]:
✗ [ERR] http://office.microsoft.com/en-001/excel-help/create-a-custom-number-format-HP010342372.aspx | Failed: Too many redirects: error following redirect for url (http://office.microsoft.com/en-001/excel-help/create-a-custom-number-format-HP010342372.aspx)

[QXlsx/source/xlsxdocument.cpp]:
✗ [ERR] http://en.wikipedia.org/wiki/Open_Packaging_Conventions | Failed: Too many redirects: error following redirect for url (http://en.wikipedia.org/wiki/Open_Packaging_Conventions)

🔍 37 Total (in 0s) ✅ 5 OK 🚫 7 Errors 💤 25 Excluded

You report contains some false positive errors
http://www.w3.org/2001/XMLSchema-instance
http://a.com/aaa.html#aaaaa
http://en.wikipedia.org/wiki/Open_Packaging_Conventions
3 of 7 errors are false positive. Maybe it's a good idea but not in current implementation

Thank you for a good report and idea! 🥇

I had no idea about dead links. 🐵

If you don't have any further comments, I'll keep this issue closed for now. You can reopen it later.