QuestCraftPlusPlus/QuestCraft

[FEATURE] Ability to add/access offline accounts post successful MS authentication

Opened this issue · 4 comments

jr0n commented

📝 Is your feature request related to a problem? Please describe

The option to create/play offline accounts doesn't exist unless Wi-Fi is disabled on the quest. This prevents LAN play for self hosted Minecraft servers.

🛠️ Describe the solution you'd like

Once a Microsoft account has been successfully authenticated in QuestCraft, the option to add an offline account from the menu screen without disabling Wi-Fi would greatly improve the quality of life for parents in control of their children's Minecraft accounts. This is similar to how other launchers like Prism Launcher and FjordLauncher handle piracy prevention. This change also helps users avoid future authentication issues like those found at PrismLauncher/PrismLauncher#2302 and PrismLauncher/PrismLauncher#2302 (comment) when self hosting servers in offline mode.

🤔 Describe alternatives you've considered

No response

ℹ️ Anything else?

No response

Killerminigun commented

This is almost 100% not going to happen

Cartrigger commented

This is possible. Our devs are currently on break though.

  • ❤️1
TheReal-Flo commented

I don't know why it's necessary tho. There are plenty of Mods, that add exactly this behavior, for example In-Game Account Switcher on Modrinth, so it's very useless for the launcher. Also, adding this behavior to the launcher would make it easier to make a "cracked" version of QuestCraft ;)

jr0n commented

I don't know why it's necessary tho. There are plenty of Mods, that add exactly this behavior, for example In-Game Account Switcher on Modrinth, so it's very useless for the launcher. Also, adding this behavior to the launcher would make it easier to make a "cracked" version of QuestCraft ;)

Thanks for the mod suggestion. I'll give it a try with QuestCraft when I find some time.

I respectfully disagree that enabling offline accounts post MS authentication will help enable piracy in any significant way. The use case for this change with regard to piracy is limited at best when considering the technical and financial hurdles involved in making offline play viable:

  1. A VR headset is required for QuestCraft
  2. Offline mode is already supported in QuestCraft when Wi-Fi is disabled
  3. Multiplayer "offline" support requires the use of separate server infrastructure and is basically restricted to restricted to LAN play without additional VPN layers or third party authentication APIs (drasl).
  4. The code is already open source and requires a one line change to completely bypass MS authentication
  5. Mojang has supported offline play as far back is I can recall and MS/Mojang continues to support it

This request is just a quality of life change that allows people to enjoy the game in a supported mode after already authenticating. I shouldn't need to tell my kids to login via MS and if the token expires, ask me to check my email to for security codes so they can continue to play on their offline server.