Code Review of Tweet Generator Submission 1
Opened this issue · 0 comments
SWHarrison commented
- dictionary_words works as expected. I encourage you to add benchmarking, and trying different methods of extracting the words. One possibility is to extract words while reading them in originally, rather than reading the entire file then randomly selecting a few of them.
- Great job creating all types of histograms and benchmarking. I encourage you to try creating the list of counts without utilizing the dictionary histogram as a further challenge.
- Sampling works as expected, and thank you for creating a great test function. I encourage you to write a function to sample a list of counts. The main advantage to the list of counts is faster sampling, so it's a great way to contrast different tradeoffs for the 4 histogram types you implemented.
- App works great, I encourage adding a little more CSS and greek imagery to make it look nice and authentic.
- Markov chain works well. I recommend you look into start/stop tokens, or into higher order markov chains to push your understanding of these data structures.