withId and withName

[lenrik1589]

Vanilla Identifiers support using strings to make actual identifier so I believe having jut Identifier be accepted is not the best

quilt-kotlin-libraries/wrapper/minecraft/src/main/kotlin/org/quiltmc/qkl/wrapper/minecraft/registry/RegistryDsl.kt

Line 56 in 2a4f49b

public infix fun T.withId(id: Identifier) {

so withName is confusing as for me personally it reffers to a TranslatedText or LiteralText name

quilt-kotlin-libraries/wrapper/minecraft/src/main/kotlin/org/quiltmc/qkl/wrapper/minecraft/registry/RegistryDsl.kt

Line 68 in 2a4f49b

public infix fun T.withName(name: String) {

So a proper withId would be as such

public infix fun T.withId(id: Identifier) {
    Registry.register(registry, id, this)
}


public infix fun T.withId(id: String) {
    Registry.register(registry, if(":" in id || modid == null){
        Identifier(id)
    } else {
        Identifier(modid, id)
    }, this)
}

[Peanuuutz]

Mean to take on this job.

[lenrik1589]

also noticed discrepancy with actual behaviour at

quilt-kotlin-libraries/wrapper/minecraft/src/main/kotlin/org/quiltmc/qkl/wrapper/minecraft/registry/RegistryDsl.kt

Line 63 in 2a4f49b

* If no modid is present, it uses `"modid:name"` format.

which should be

     * If no `modid` is present, it uses `"minecraft:name"` format.