Install script targets wrong moonraker.conf and directory in RatOS.
Closed this issue · 9 comments
Hi! I have several users reporting problems with the octoeverywhere install script modifying the RatOS git repository.
Instead of finding /home/pi/printer_data/config/moonraker.conf it finds /home/pi/printer_data/config/RatOS/moonraker.conf (which is included by /home/pi/printer_data/config/moonraker.conf) modifies that, and dumps its files in /home/printer_data/config/RatOS/
Any particular reason it's doing a depth first search here? Or is it looking for specific content in moonraker.conf? What's going on?
@miklschmidt, thanks for letting me know! I'm working on rewriting the installer, which will make it much more robust and let me handle more special case installs like RatOS. When it's complete, I will follow up and make sure the issue is resolved!
@QuinnDamerell Awesome! let me know when i can release the horde for a test run! :D
Also if there's anything else i can help with, please let me know :)
@miklschmidt no problem! Can I ask, do you know of anyone who runs multiple instances of moonrakeer and klipper on one RatOS device?
@QuinnDamerell None, it's currently not supported :)
@miklschmidt perfect! Ok, I pushed the new installer to master! I explicitly tested it on RatOS to ensure it discovered things correctly, and it looks good!
If you find a minute, pull the current repo and run the ./install.sh script again to see if it works for you! If it's currently installed in the wrong location, it should be re-install into the correct place.
@QuinnDamerell i ran it on my test machine, and it looks good to me! I've asked the users to give it a go again, i'll let you know if i hear of anymore problems but for now i consider it fixed :)
Perfect! Thanks for bringing this up and please let me know if you hit any other issues in the future!
Btw, the installer is safe to run anytime, even for recovery and such. But in this one case, users might have to re-link their printers, because a of files moving around.
Excellent, i've issued a PSA on discord letting people know, thanks for the fix!