BawAudioTools::Exceptions::AudioToolTimedOutError leaves zombie processes behind

When BawAudioTools::Exceptions::AudioToolTimedOutError is raised the process runner is meant to clean up child processes.

Instead they're left behind as zombie processes.

The following code does not seem to be working:

baw-server/lib/gems/baw-audio-tools/lib/baw_audio_tools/run_external_program.rb

Lines 122 to 126 in 349ff8d

    
           # We need to kill the process, because killing the thread leaves 
        
           # the process alive but detached, annoyingly enough. 
        
           # Sending TERM (15) instead of KILL (9) to allow clean up rather than 
        
           # dirty exit 
        
           Process.kill('TERM', pid)

Samples taken from a recent incident on a server:

$ ps -aux | grep "<defunct>" | wc -l
3828

	# We need to kill the process, because killing the thread leaves
	# the process alive but detached, annoyingly enough.
	# Sending TERM (15) instead of KILL (9) to allow clean up rather than
	# dirty exit
	Process.kill('TERM', pid)