typescript
PaulieScanlon opened this issue · 7 comments
Hello Mr @thejackshelton, not sure if it's this package or some other dependancy... but
I didn't have typescript installed in my Astro project, and it's not named as peer dependency in this package so Astro errored when i spun up the dev server.
Simple fix of course, i just installed typescript, but it might be helpful if its mentioned as part of the install scripts, e.g
# Using NPM
npx astro add @qwikdev/astro typescript
# Using Yarn
yarn astro add @qwikdev/astro typescript
# Using PNPM
pnpm astro add @qwikdev/astro typescript
Hello Mr @thejackshelton, not sure if it's this package or some other dependancy... but
I didn't have typescript installed in my Astro project, and it's not named as peer dependency in this package so Astro errored when i spun up the dev server.
Simple fix of course, i just installed typescript, but it might be helpful if its mentioned as part of the install scripts, e.g
# Using NPM npx astro add @qwikdev/astro typescript # Using Yarn yarn astro add @qwikdev/astro typescript # Using PNPM pnpm astro add @qwikdev/astro typescript
Ah good point! Let me go do that :) . I think typescript comes out of the box with the latest cli, but not for existing projects.
Ah yeah, so when you start a new Astro project it adds TypeScript already. Should I bother with it? Maybe a note to add it in the readme for existing projects?
That is running the Astro CLI without adding the qwik integration yet. I think they added that as a dependency since.
Hey mate, yes, you're correct, with a new Astro project Typescript is installed but you can uninstall it and Astro still works, where as, Qwik errors so arguably, it should be installed as a peer dep.
Hey mate, yes, you're correct, with a new Astro project Typescript is installed but you can uninstall it and Astro still works, where as, Qwik errors so arguably, it should be installed as a peer dep.
Sounds good, will add it as a peer dep now :)
Should be fixed in 0.3.8 😄
The man, the legend! Always so Qwik 😊
The man, the legend! Always so Qwik 😊
Haha gotta stay on brand.