QwikDev/qwik

[🐞] Version 1.5.3 build is broken: Cannot load native addon because loading addons is disabled

ohkimur opened this issue · 11 comments

ohkimur commented

Which component is affected?

Qwik Rollup / Vite plugin

Describe the bug

Starting with v1.5.3 the vite build fails. This fails in a few different environments, including the official vite template for qwik. Check it out here.

Also, starting with this version, qwik doesn't respect custom rollup configs from vite properly, including custom dir, and entryFileName options.

NOTE: I'm working on a very big design system that supports all the major frameworks including qwik. For each one of them I build to dist. It would be great to be able to keep doing this for qwik.

Reproduction

https://stackblitz.com/edit/vitejs-vite-zyuten?file=package.json

Steps to reproduce

No response

System Info

System:
    OS: macOS 14.4.1
    CPU: (16) arm64 Apple M3 Max
    Memory: 8.46 GB / 64.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 21.7.2 - ~/.nvm/versions/node/v21.7.2/bin/node
    npm: 10.5.0 - ~/.nvm/versions/node/v21.7.2/bin/npm
    pnpm: 9.0.6 - ~/Library/pnpm/pnpm
    bun: 1.0.35 - ~/.bun/bin/bun
  Browsers:
    Chrome: 124.0.6367.119
    Safari: 17.4.1

Additional Information

No response

PatrickJS commented

it might have been caused by
#6178
or
#6162

what do you think @wmertens

  • 👀1
PatrickJS commented

@ohkimur can you stay on 1.5.2 until we fix it

  • 👍1
PatrickJS commented

csr: true will be fixed in next release #6292

  • 🚀1
wmertens commented

Ah and the dlopen issue is separate because now we ship a binary from Linux and it tries to use it in stackblitz.

So we need to be more careful about that.

JerryWu1234 commented

What can I do here ?

PatrickJS commented

@wmertens you can outline what @JerryWu1234 can do 🙌

ohkimur commented

@PatrickJS Do we have any update on this topic? I'm wondering if there's something I could help with. I see the vite-demo still is failing to compile. The same happens still when I update to v1.5.5.

PatrickJS commented

@wmertens is the only one with enough context on what to fix here

  • 👍1
wmertens commented

This is a cosmetic error. It shows that and then it uses wasm instead. I have a fix already but it's in a PR that's blocked right now, I'll add it separately when I get a chance.

  • 👍1
ohkimur commented

@wmertens Can you mention me in the PR? I'd like to take a look and understand the problem deeper if possible.

wmertens commented

@ohkimur it's this commit 2b5384c

  • 👀1