[๐] Route is broken with deep nesting
mhuretski opened this issue ยท 4 comments
mhuretski commented
Which component is affected?
Qwik City (routing)
Describe the bug
Hi,
When using [...lang] catchall route at the root of the routing, deeply nested routes are broken if lang is not provided.
src/routes/[...lang]/
โ
โโโ (app)/
โ โโโ index.tsx
โ โโโ layout.tsx
โ
โโโ some/
โ โโโ deep/
โ โโโ nested/
โ โโโ [id]/
โ โ โโโ index.tsx (broken without "lang")
โ โโโ index.tsx
โ
โโโ working/
โโโ nesting/
โโโ [id]/
โโโ index.tsx
/some/deep/nested/some_id - broken
/some_lang/some/deep/nested/some_id - OK
/some/deep/nested - OK
/some_lang/some/deep/nested - OK
/working/nesting/some_id - OK
/some_lang/working/nesting/some_id - OK
Catchall route doesn't seem to be a great fit as an optional route, perhaps adding something like [?lang] could simplify routing logic with deep nesting to avoid this issue?
Reproduction
Steps to reproduce
No response
System Info
"@builder.io/qwik": "^1.5.4",
"@builder.io/qwik-city": "^1.5.4",
Additional Information
No response
JerryWu1234 commented
may I pick this up ?
gioboa commented
may I pick this up ?
Go for it ๐ Thanks
JerryWu1234 commented
maybe it can directly close this Issue?
PatrickJS commented
oh yeah this was fixed in 1.5.5