R1j1t/contextualSpellCheck

dependency version number in setup.py

R1j1t opened this issue · 3 comments

R1j1t commented

This will help prevent code break when some user has an old dependency.

Considerations: Will need to check the lowest version to minimise the unnecessary updates

AlvinKuruvilla commented

Hi I would like to take up this issue, how exactly would we go about checking minimum versions?

R1j1t commented

Thanks @AlvinKuruvilla for your contribution! There is no restriction to have the lowest version possible as dependency. You can check if all the tests pass for the last major release (1.x or 2.x etc) for the core dependency.

contextualSpellCheck/setup.py

Line 31 in f8cbeb8

install_requires=["torch", "editdistance", "transformers", "spacy"],

If the tests fail then maybe will have to check the required minor version based on the test result.