R2Northstar/NorthstarMods

Dropship related crash

GeckoEidechse opened this issue · 3 comments

Sent to me by Iniquity

[08:09:27] [SCRIPT SV] [info] SCRIPT ERROR: [SERVER] Player is already alive.
[08:09:27] [SCRIPT SV] [info]  -> this.Code_RespawnPlayer( ent )
[08:09:27] [SCRIPT SV] [info] 
CALLSTACK
*FUNCTION [CPlayer()] class/CPlayer.nut line [72]
*FUNCTION [SpawnPlayerIntoDropship()] mp/_classic_mp_dropship_intro.gnut line [191]

[08:09:27] [SCRIPT SV] [info] LOCALS
[ent] NULL
[this] ENTITY (player killerofkingsYT [1] (player "killerofkingsYT" at <-3785.33 -1505.03 715.668>))
[playerDropshipIndex] 1
[playerDropship] unknown struct
[teamDropships] ARRAY
[player] ENTITY (player killerofkingsYT [1] (player "killerofkingsYT" at <-3785.33 -1505.03 715.668>))
[this] TABLE

DIAGPRINTS

Having the same issue. My (docker) server is crashing every 2-3 games. Only FSU and BTB are installed.

[01:26:33] [SCRIPT SV] [info] SCRIPT ERROR: [SERVER] Player is already alive.
[01:26:33] [SCRIPT SV] [info]  -> this.Code_RespawnPlayer( ent )
[01:26:33] [SCRIPT SV] [info]
CALLSTACK
*FUNCTION [CPlayer()] class/CPlayer.nut line [72]
*FUNCTION [SpawnPlayerIntoDropship()] mp/_classic_mp_dropship_intro.gnut line [191]
[01:26:33] [SCRIPT SV] [info] LOCALS
[ent] NULL
[this] ENTITY (player DeadBodyCascade [4] (player "DeadBodyCascade" at <-4319.44 -674.769 1429.92>))
[playerDropshipIndex] 2
[playerDropship] unknown struct
[teamDropships] ARRAY
[player] ENTITY (player DeadBodyCascade [4] (player "DeadBodyCascade" at <-4319.44 -674.769 1429.92>))
[this] TABLE
DIAGPRINTS
abnormal program termination
0024:fixme:msvcrt:__clean_type_info_names_internal (0000000005168788) stub
nswrap: northstar exited with status 3
nswrap: killing xvfb
nswrap: waiting for children to exit```

In case it helps, I "fixed" this by simply adding an alive check that skips executing this.Code_RespawnPlayer( ent ) after the WaitFrame() in SpawnPlayerIntoDropship() if a player is alive, assuming that the player has already been otherwise spawned correctly, this should cause no issue.

I've not seen a crash since. ikhadhonger also applied my "fix", and saw the same result.

I have no clue if my change causes some other issue, if one player randomly gets screwed by spawning in a way that's bugged, or something, but I know for sure it prevents a crash.

Same issue, same fix