fstream to basic_iostream in RinexStream
jonyrock opened this issue · 4 comments
jonyrock commented
There is https://github.com/jonyrock/Gpstk/blob/master/dev/ext/lib/FileHandling/FFStream.hpp which base for all FF* classes. I suppose we need also change lib/FileHandling to lib/DataHandling
jonyrock commented
@eugenyk I want to underline that we can't change FFStream interface, so the original constructors should remain.
jonyrock commented
jonyrock commented
@eugenyk please review the changes. Looks like it works. I think that the heart of my solution is
dev/ext/lib/FileHandling/FFStream.hpp
(see all diff of this file) and here https://github.com/jonyrock/Gpstk/blob/bfd61eb6d30adb3bdfb07fc38bc8ff02bdcfeed0/dev/ext/lib/FileHandling/FFStream.cpp#L70
eugenyk commented
Sources reviewed, comments added. std::iostream inheritance really looks more consistent