RISC-OS-Community/WakeOnLAN

MAC address is not saved

mattharris opened this issue · 2 comments

Background

When choosing 'Save Options' in the UI, the IP Broadcast Addr is saved, but not the Target MAC Addr.

Questions

  • Is this intentional behaviour?
  • Would it not make more sense to also save the MAC address?
  • If this is intended, what is the rationale? (Just trying to understand intended use case)

The initial thought was that the MAC would constantly change, but I think maybe many people may just need to start a specific machine, so they may prefer that the UI saves also the MAC address.

It's open for discussion, whatever people wants is ok for me.

@RISC-OS-Community/code-reviews-team should we also save the MAC address when a user saves the option in WakeOnLAN?

Ok, tested latest updates straight from the packman repo and MAC is now been saved when the user saves the options. I guess we can close this issue :)

In case it's needed we can open it again, thanks.