ROCm/ROCm-Device-Libs

Request to cherry-pick 66a1c5b for LLVM 15

GZGavinZhao opened this issue · 3 comments

GZGavinZhao commented

Currently no version of ROCm-Device-Libs can be built with LLVM 15 and above because LLVM 15 fully switched to opaque pointers. You will get an error like below that is caused by the __llvm_amdgcn_global_atomic_fadd_f32_p1f32_f32 function in the ockl/src/gaaf.cl file:

FAILED: ockl/gaaf.bc /home/build/YPKG/root/rocm-device-libs/build/ROCm-Device-Libs-rocm-5.2.3/solusBuildDir/ockl/gaaf.bc 
cd /home/build/YPKG/root/rocm-device-libs/build/ROCm-Device-Libs-rocm-5.2.3/solusBuildDir/ockl && /usr/bin/clang-15 -I/home/build/YPKG/root/rocm-device-libs/build/ROCm-Device-Libs-rocm-5.2.3/ockl/../irif/inc -I/home/build/YPKG/root/rocm-device-libs/build/ROCm-Device-Libs-rocm-5.2.3/ockl/../oclc/inc -I/home/build/YPKG/root/rocm-device-libs/build/ROCm-Device-Libs-rocm-5.2.3/ockl/inc -fcolor-diagnostics -Werror -Wno-error=atomic-alignment -x cl -Xclang -cl-std=CL2.0 -target amdgcn-amd-amdhsa -fvisibility=protected -fomit-frame-pointer -Xclang -finclude-default-header -nogpulib -cl-no-stdinc -Xclang -mcode-object-version=none -emit-llvm -Xclang -mlink-builtin-bitcode -Xclang /home/build/YPKG/root/rocm-device-libs/build/ROCm-Device-Libs-rocm-5.2.3/solusBuildDir/irif/irif.bc -c /home/build/YPKG/root/rocm-device-libs/build/ROCm-Device-Libs-rocm-5.2.3/ockl/src/gaaf.cl -o /home/build/YPKG/root/rocm-device-libs/build/ROCm-Device-Libs-rocm-5.2.3/solusBuildDir/ockl/gaaf.bc
'+atomic-fadd-insts' is not a recognized feature for this target (ignoring feature)
'+atomic-fadd-insts' is not a recognized feature for this target (ignoring feature)
Intrinsic name not mangled correctly for type arguments! Should be: llvm.amdgcn.global.atomic.fadd.f32.p1.f32
ptr @llvm.amdgcn.global.atomic.fadd.f32.p1f32.f32
fatal error: error in backend: Broken module found, compilation aborted!
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script.

This commit fixed the issue almost a year ago but is not yet available in any of the releases. Could you please cherry-pick this commit to the next release?

Thank you!

searlmc1 commented

Hi ,

That commit will be in the next ROCm release

Thanks

GZGavinZhao commented

Thanks!

searlmc1 commented

ROCm 5.5.0 was released yesterday; the commit is in that release; thanks much