ROCm/rdc

rdc.h doesn't compile under C with gcc

morrone opened this issue · 4 comments

There hasn't been any progress getting this fixed in ROCm/ROCm#1641, so I wanted to try it here in the repo with the problem header.

As mentionted in that ticket, in include/rdc/rdc.h, we need MAX_TEST_CASES to be changed from a "const uint32_t" into a define. The gcc compiler does not allow the rdc.h to compile unless that change is made.

This discussion explains why the "const" usage is not technically correct:

https://stackoverflow.com/questions/21592494/initializer-element-is-not-constant-error-for-no-reason-in-linux-gcc-compilin

@bill-shuzhou-liu , is this something that will be fixed in the next release? It looks like an easy one-line fix, but its causing a lot of issues until it is fixed.

Yes, it will be fixed in the next release. Thanks.

fixed as of 5.5 73d8b35

Thank you! This is much appreciated.