find_package (ROCM is confusing

Question

find_package (ROCM is confusing

saadrahim opened this issue 3 years ago · 3 comments

Invoking
find_package( ROCM 0.5 CONFIG QUIET PATHS ${ROCM_PATH} /opt/rocm )
to include rocm-cmake is confusing.

We should consider changing the name to ROCM-CMAKE.

Answer 1 · 2021-09-29T19:38:47.000Z

@pfultz2 Can you weigh in on this? Using the name ROCM is confusing, especially with the version numbers which don't match the ROCm version number, and we have the opportunity to make a breaking change with ROCm 5.0.

Answer 2 · 2024-04-30T01:45:20.000Z

Hi @saadrahim, is there any further work required for this ticket? Can I close it? Thanks.

Answer 3 · 2024-04-30T15:39:10.000Z

It is find_package(ROCmCMakeBuildTools) in ROCm 6.1 and later, although find_package(ROCM) remains available for backwards-compatibility.