find_package (ROCM is confusing
saadrahim opened this issue · 3 comments
saadrahim commented
Invoking
find_package( ROCM 0.5 CONFIG QUIET PATHS ${ROCM_PATH} /opt/rocm )
to include rocm-cmake is confusing.
We should consider changing the name to ROCM-CMAKE.
lawruble13 commented
@pfultz2 Can you weigh in on this? Using the name ROCM
is confusing, especially with the version numbers which don't match the ROCm version number, and we have the opportunity to make a breaking change with ROCm 5.0.
nartmada commented
Hi @saadrahim, is there any further work required for this ticket? Can I close it? Thanks.
cgmb commented
It is find_package(ROCmCMakeBuildTools)
in ROCm 6.1 and later, although find_package(ROCM)
remains available for backwards-compatibility.